Laggy Reordering Of Folder Favorites

[Darius1968]

As of the latest version of IMatch, I now find that when I try to reorder the folder favorites in the Favorites panel, it is now very laggy, stalling a few seconds or so, for every one or two places the the item is shifted in either direction.  I've attached my log file here for troubleshooting.  I've never had this up until now. 

[Mario]

Do you use standard icons? Or external icons?
Do you have many favorites in the File Window toolbar?
Many application favorites?

I see an unusually high number of icon reloads via Windows shell functions. And these function calls are slow, since they spend most of their time in the Windows file system.
This means each time IMatch has to refresh the icon cache after modifications were made to favorites, it will spend a lot of time waiting for Windows.

[Darius1968]

I have four favorites in the File Window toolbar (icons for which:  2 standard, 2 external).  There's one application favorite.  I've discovered that I can make the problem go away by disabling experimental features. 

[Mario]

There's one application favorite.  I've discovered that I can make the problem go away by disabling experimental features. 

I'll make this a bug report then.
The code that deals with the favorite icons is the same between the normal toolbars and the new ribbons. There should be no difference. I will see if can repro this while processing your bug report.

[ubacher]

Note that I had my problem also when moving favorites as reported in:
https://www.photools.com/community/index.php/topic,14324.msg100713.html#msg100713

[Mario]

Note that I had my problem also when moving favorites as reported in:
https://www.photools.com/community/index.php/topic,14324.msg100713.html#msg100713

The crash DUMP indicates a crash caused by Windows providing an invalid argument to an owner-drawn button in the Filter panel. I don't see how this is related to slow responses when a user has many favorites with external and shell icons.

[Mario]

The problem was caused by IMatch reloading all shell and external icons on each move. It simply reacted on "favorite modified".
The move case is now a special case and avoids triggering the icon update. This makes moving favorites very fast again.