Hotkeys listed for assigning XMP Labels include Num Pad, but don't work.

Started by GrantRobertson, August 15, 2023, 06:01:04 PM

Previous topic - Next topic

GrantRobertson

It's a little hard to describe this bug in the subject line due to limited space.

In the context menu that we use to assign an XMP Label to an image, shown here:
NumPad Bug - 01.jpg
... where it shows the hotkeys (shortcut keys) that one could use, it lists using numbers on the "Num pad" as an option (in the red boxes). Unfortunately, this does not work at all. 

When pressing Shift plus any key on the number pad, the key press just gets interpreted as if I was pressing an arrow key. And, before you say it: Yes, the NumLock is on, as most sane people keep it when using a normal keyboard with separate arrow keys.

Here's the thing: It does the same thing whether the NumLock is on or not. Even whether I press the Shift key or not. IMatch always interprets any press of a key on the number pad as a directional key, as if NumLock was not a thing that existed in this universe. 

The "easy fix" for this would be to simply remove that extra text (in the red boxes in the attached screen captures) from the context menu. However, people expect the numbers on their number pad to work as, you know, numbers (when NumLock is on). Most people expect there to be no difference between pressing a number key on the main keyboard and pressing a number key on their number pad. 

Now, I am aware that holding Shift while pressing a number pad key is often used as an override of the NumLock state when NumLock is on. However, I am pretty sure that almost no one else is aware of that or makes use of that. Hell, I only just now discovered it while experimenting in my text editor while figuring out this bug, and I'm a former network manager. It is unfortunate that you chose the one modifier key that conflicts with "standard" (if unknown) use of the number pad. But since you have chosen to use the Shift key as the modifier for when assigning AMP Labels, I offer the following suggestions:

First: Hard code IMatch to always interpret use of the number pad keys as numbers, whether the shift key is pressed or not. We all have regular arrow keys on our keyboards. Honor the NumLock state, because that is what people expect. I know this complicates things, because the Shift key has conflicting usages here. But, I'm sure you already know how to read the exact keycodes being sent from the keyboard, and know how to do what you want with those keycodes. 

Second: Also remove that extra text, in my red boxes, from the context menu. It just complicates things and confuses the user. Just indicating for the user to use Shift+1 (or whatever digit) will be enough. They already know that they should be able to use either the number keys above the letter keys or the number keys on the number pad. You don't need to remind them. It's like reminding someone that they can either turn the doorknob to the left or the right to open the door....  every time they go through a door. They know that already.


These extraneous shortcut keys also show up in the Command Palette. I'm guessing that will go away automatically when you edit what shows up in the context menu.


Finally, a curiosity question: Why do you make use of only the digits 0-5? Why not just use all the digits here?


Mario

I read: <Shift>+<Digit> on Numpad not working, correct?

These keyboard shortcuts are ooold, dating back to IMatch 5 in 2016. Maybe something has changed in Windows. No other user reported this so far so I guess nobody uses them. I'll look into it for some later release.

QuoteFinally, a curiosity question: Why do you make use of only the digits 0-5? Why not just use all the digits here?
IMatch will use 1 to 5 + 0, if you have enough labels.

image1.jpg

(German keyboard, hence German keyboard names).

By default, IMatch ship with a set of about 20 labels (Edit > Preferences > , matching the most common XMP labels used by popular applications and RAW processors. I assume you have deleted these default labels?

Image2.jpg

See XMP Labels

-- Mario
IMatch Developer
Forum Administrator
http://www.photools.com  -  Contact & Support - Follow me on 𝕏 - Like photools.com on Facebook

Mario

I have replaced this with <Shift>+<Ctrl>+NumPad*. It's a 3rd level fallback anyway.
-- Mario
IMatch Developer
Forum Administrator
http://www.photools.com  -  Contact & Support - Follow me on 𝕏 - Like photools.com on Facebook


GrantRobertson

Quote from: Mario on August 15, 2023, 06:58:21 PMI have replaced this with <Shift>+<Ctrl>+NumPad*. It's a 3rd level fallback anyway.
I think I'll just stick to the number keys above the letters.  ;D